Change log level from warn to debug for successfully created missing …#648
Closed
TheDGOfficial wants to merge 2 commits intoembeddedt:26.1from
Closed
Change log level from warn to debug for successfully created missing …#648TheDGOfficial wants to merge 2 commits intoembeddedt:26.1from
TheDGOfficial wants to merge 2 commits intoembeddedt:26.1from
Conversation
…block entities This message spams the logs in Hypixel. The else case already logs at error level; so logging it for the successful case would only bury the error case in the logs. I feel like debug log level would be apporiate here, which won't be logged by default at least on Fabric. I'm not sure if Forge still enables debug log level by default, please let me know.
Slightly more performant if debug logging not enabled. Could also use a Supplier taking overload of the .debug method, but that incurs additional lambda object creation that would most likely neglect any performance gains from not evaluating the toShortString method.
Owner
|
Seems reasonable. Will apply this to the 1.20 branch manually (it gets propagated upwards from there as mentioned in Out of curiosity, what Hypixel gamemode has enough block entities for this to be an issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…block entities
This message spams the logs in Hypixel. The else case already logs at error level; so logging it for the successful case would only bury the error case in the logs. I feel like debug log level would be apporiate here, which won't be logged by default at least on Fabric. I'm not sure if Forge still enables debug log level by default, please let me know.